Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added multiple sheets feature #10

Merged
merged 8 commits into from
Jan 18, 2024
Merged

added multiple sheets feature #10

merged 8 commits into from
Jan 18, 2024

Conversation

jlloyd-widen
Copy link
Contributor

This PR partially addresses Issue #4. Allows for providing an array of sheets to extract. I kept the pre-existing config for backwards compatibility but using the new sheets config option will override anything in the original set of config properties.

I did not test this with all the loaders described in the readme, jsonl only.

@ReubenFrankel
Copy link
Contributor

Hi @jlloyd-widen, thanks for this PR. Hope to review it soon, but looks good at first glance. 🙂

@ReubenFrankel ReubenFrankel added the enhancement New feature or request label Dec 14, 2023
@ReubenFrankel ReubenFrankel self-requested a review December 14, 2023 12:42
@ReubenFrankel ReubenFrankel requested review from DanielPDWalker and removed request for ReubenFrankel January 17, 2024 10:26
@ReubenFrankel
Copy link
Contributor

ReubenFrankel commented Jan 18, 2024 •
edited
Loading

Hi, sorry for the slow reply @jlloyd-widen. We will probably get this out later this week along with some other changes.

I fixed a small issue with get_sheet_name missing the stream_config positional argument, which I hit because I didn't have base-level config for output_name set (n.b. #11 corrected stream_name to output_name). There are also some minor spelling mistakes in the README, but I'll correct those closer to merge (if you want to fix them, go ahead). Otherwise, pretty much ready to go - thanks! 👍

@ReubenFrankel ReubenFrankel merged commit 3e02a6c into Matatika:master Jan 18, 2024
4 checks passed
@ReubenFrankel
Copy link
Contributor

Thanks @jlloyd-widen 👍

@ReubenFrankel ReubenFrankel removed the request for review from DanielPDWalker January 18, 2024 12:41
@ReubenFrankel ReubenFrankel mentioned this pull request Jan 18, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jlloyd-widen @ReubenFrankel